fix(filterFilter): make $ match properties on deeper levels as well - #10408

what is the extra line adding?

It makes sure that a string property only matches its level (as long as the key isn't $).
I.e. it tests that {name: 'Jo'} won't match against {name: {first: 'John'...}}.

See #10401 (comment); the previous test-suite was passing even with an incorrect implementation.

fair enough --- might want to add a comment explaining this

Sure. Do you think it would be better to put it in a separate it block ?

I don't have a strong opinion on that --- you get some extra lines of code if you add a new spec, fine with me either way

i still want a comment clearly explaining this line, but otherwise lgtm

I put it in a new it block (along with 2 new lines :)). Isn't the it description clear enough ?

(BTW, take a look at #10401 (comment). You might not even want this behaviour...)

No this is the right behaviour --- named properties only match against that named property in that level. I thought you meant adding another it block in addition to the one that was already there.

I think the spec name isn't really clear about the intention of that line, it takes some digging to get the intent of it.

I did add another it in addition to the one that was already there. The one already there is at https://github.com/angular/angular.js/pull/10408/files#diff-32d73862cc8a915aba9ab0d7b1c78c17R89.

The git diff shows it as if I replaced should respect the depth level of a "$" property with this one, but they are unrelated. (It's actually the following test that replaces the old one.)

How about that:
should match named properties only against named properties on the same level